fixed log_p_x function compat for cifar dataset #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
during our pod proceedings, we found that the log_p_x function caused issues down the road if you were using the CIFAR dataset because it failed to account for the additional dimensions. this fixed that with a ternary operator
j6k4m8
reviewed
Apr 1, 2023
Contributor
j6k4m8
left a comment
j6k4m8
left a comment
There was a problem hiding this comment.
Thanks so much for the edits! Would it be possible to just push the changed lines to avoid the excessive diff?
fyy26
requested changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during our pod proceedings, we found that the log_p_x function caused issues down the road if you were using the CIFAR dataset because it failed to account for its additional dimensions. this fixes that with a ternary operator.