Skip to content

Refactor/module 001 align architecture csr #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zaiidmo merged 32 commits into from
Mar 5, 2026

fix(security): eliminate ALL password literals using dynamic constants

59a3eae
Select commit
Loading
Failed to load commit list.
Merged

Refactor/module 001 align architecture csr #12

fix(security): eliminate ALL password literals using dynamic constants
59a3eae
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 5, 2026 in 35s

Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 7 in test/repositories/user.repository.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'Model'. 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRTiSpHPxYsJCrcD&open=AZy9XRTiSpHPxYsJCrcD&pullRequest=12

Check failure on line 595 in test/controllers/auth.controller.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Review this potentially hard-coded password. 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRUtSpHPxYsJCrcd&open=AZy9XRUtSpHPxYsJCrcd&pullRequest=12

Check warning on line 227 in test/repositories/user.repository.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "resultPromise". 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRTiSpHPxYsJCrcF&open=AZy9XRTiSpHPxYsJCrcF&pullRequest=12

Check warning on line 6 in jest.config.cjs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`String.raw` should be used to avoid escaping `\`. 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRV4SpHPxYsJCrcm&open=AZy9XRV4SpHPxYsJCrcm&pullRequest=12

Check warning on line 6 in test/repositories/role.repository.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'Model'. 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRTUSpHPxYsJCrcC&open=AZy9XRTUSpHPxYsJCrcC&pullRequest=12

Check warning on line 97 in test/controllers/roles.controller.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRVPSpHPxYsJCrcj&open=AZy9XRVPSpHPxYsJCrcj&pullRequest=12

Check warning on line 327 in test/integration/rbac.integration.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "signature". 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRUMSpHPxYsJCrcP&open=AZy9XRUMSpHPxYsJCrcP&pullRequest=12

Check warning on line 6 in test/repositories/permission.repository.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'Model'. 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRT3SpHPxYsJCrcH&open=AZy9XRT3SpHPxYsJCrcH&pullRequest=12

Check warning on line 10 in test/auth.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9i4pwJp304WWPclGb&open=AZy9i4pwJp304WWPclGb&pullRequest=12

Check warning on line 132 in test/controllers/roles.controller.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRVPSpHPxYsJCrcl&open=AZy9XRVPSpHPxYsJCrcl&pullRequest=12

Check warning on line 176 in test/controllers/users.controller.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRU_SpHPxYsJCrci&open=AZy9XRU_SpHPxYsJCrci&pullRequest=12

Check warning on line 327 in test/integration/rbac.integration.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "payload". 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRUMSpHPxYsJCrcO&open=AZy9XRUMSpHPxYsJCrcO&pullRequest=12

Check warning on line 156 in test/controllers/users.controller.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRU_SpHPxYsJCrch&open=AZy9XRU_SpHPxYsJCrch&pullRequest=12

Check warning on line 3 in test/integration/rbac.integration.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'INestApplication'. 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRUMSpHPxYsJCrcI&open=AZy9XRUMSpHPxYsJCrcI&pullRequest=12

Check warning on line 125 in test/controllers/users.controller.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRU_SpHPxYsJCrcf&open=AZy9XRU_SpHPxYsJCrcf&pullRequest=12

Check warning on line 142 in test/controllers/users.controller.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRU_SpHPxYsJCrcg&open=AZy9XRU_SpHPxYsJCrcg&pullRequest=12

Check warning on line 244 in test/repositories/user.repository.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "resultPromise". 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRTiSpHPxYsJCrcG&open=AZy9XRTiSpHPxYsJCrcG&pullRequest=12

Check warning on line 108 in test/controllers/permissions.controller.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRUdSpHPxYsJCrcT&open=AZy9XRUdSpHPxYsJCrcT&pullRequest=12

Check warning on line 4 in test/integration/rbac.integration.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'request'. 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRUMSpHPxYsJCrcJ&open=AZy9XRUMSpHPxYsJCrcJ&pullRequest=12

Check warning on line 94 in test/controllers/permissions.controller.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRUdSpHPxYsJCrcS&open=AZy9XRUdSpHPxYsJCrcS&pullRequest=12

Check warning on line 111 in test/controllers/roles.controller.spec.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRVPSpHPxYsJCrck&open=AZy9XRVPSpHPxYsJCrck&pullRequest=12

Check warning on line 36 in src/guards/authenticate.guard.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=CISCODE-MA_AuthKit&issues=AZy9XRQHSpHPxYsJCrbs&open=AZy9XRQHSpHPxYsJCrbs&pullRequest=12
View more details on SonarQubeCloud