Skip to content

infrastructure adapters #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
y-aithnini wants to merge 1 commit into from
Closed

infrastructure adapters #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,32 @@
"reflect-metadata": "^0.2.2",
"rxjs": "^7"
},
"peerDependenciesMeta": {
"nodemailer": {
"optional": true
},
"twilio": {
"optional": true
},
"@aws-sdk/client-sns": {
"optional": true
},
"@vonage/server-sdk": {
"optional": true
},
"firebase-admin": {
"optional": true
},
"mongoose": {
"optional": true
},
"handlebars": {
"optional": true
},
"nanoid": {
"optional": true
}
},
Comment on lines +53 to +78
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

peerDependenciesMeta entries only take effect for packages that also appear in peerDependencies. Right now these optional adapters (nodemailer/twilio/aws-sdk/etc.) are not listed in peerDependencies, so consumers won’t get correct peer dependency metadata/warnings. Suggest adding version ranges for these packages under peerDependencies and keeping them marked optional via peerDependenciesMeta (and optionally add them as devDependencies for CI/typecheck where needed).

Copilot uses AI. Check for mistakes.
"dependencies": {
"zod": "^3.24.1"
},
Expand Down
Loading