Ignore tool_call payloads inside fenced code blocks and chat envelopes; stream-aware code-fence tracking#149
Merged
CJackHwang merged 7 commits intodevfrom Mar 22, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b108a7915a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…odex/fix-markup-bypass-in-tool-call-parsing
…ol-call-parsing Do not promote fenced code examples to tool calls and centralize tool-keyword detection
CJackHwang
added a commit
that referenced
this pull request
Mar 22, 2026
Merge pull request #149 from CJackHwang/codex/fix-tool-miscall-during-complex-json-test Ignore tool_call payloads inside fenced code blocks and chat envelopes; stream-aware code-fence tracking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
tool_callsthat appear only inside fenced code examples or inside chat transcript envelopes.Description
stripFencedCodeBlocks/shouldSkipToolCallParsingForCodeFenceExamplein both JS and Go parsers.tool_callsfield usingisLikelyChatMessageEnvelope/isLikelyChatMessageEnvelopein both languages.TOOL_SIEVE_CONTEXT_TAIL_LIMITfrom256to4096and adding incremental fence tracking (codeFenceStack,codeFencePendingTicks,codeFenceLineStart), plusinsideCodeFenceWithState,updateCodeFenceState, and related simulation helpers.findToolSegmentStartandconsumeToolCapture, and add markup-syntax checks to avoid false positives.toolcalls_candidates.go,toolcalls_parse.go) and add unit tests and expected fixtures updates to cover ignoring fenced JSON blocks, chat envelope cases, chunk-split fences, nested fences, and legacy behavior adjustments.Testing
go test ./...) and Node tests (npm test/ test suite used in repository), including new tests for fenced JSON ignoring, transcript envelope ignoring, chunk-split fence handling, and nested fences, and all tests passed.tests/compat/expected) to reflect the new behavior for fenced examples and validated against the test expectations.tool_callsoutside of ignored contexts.Codex Task