Preserve unknown tool calls and original names; relax allowlist filtering and adjust stream handling#152
Closed
CJackHwang wants to merge 3 commits intodevfrom
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
availableToolNamesis empty or doesn't include the parsed name, and original tool name casing is kept (changes ininternal/util/*andinternal/js/helpers/*).seenNameswith the original parsed name (changes ininternal/adapter/openai/handler_toolcall_format.goandinternal/js/chat-stream/toolcall_policy.js).bufferToolContentis set, removing the preemptiveParseToolCallsdetection that triggered early finalization (change ininternal/adapter/claude/stream_runtime_core.go).tool_callswhere applicable (tests underinternal/adapter/openai,internal/adapter/responses,internal/util, andtests/node).Testing
go test ./...covering modified packages (internal/util,internal/adapter/openai,internal/adapter/claude, etc.) and updated tests; all tests passed.npm test/node test runner (tests undertests/node/stream-tool-sieve.test.js) and they passed.Codex Task