Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 풀요청은 매칭 화면의 구조를 개선하여 관심사 및 중요 옵션 선택 드로어를 각 섹션 컴포넌트 내부에 통합하고, ScreenMatching의 상태 관리를 간소화했습니다. 또한 Drawer 공통 컴포넌트의 UI 사양을 조정하고 MatchingSliderButton에 쉬머 애니메이션과 스타일 수정을 적용했습니다. 리뷰 결과, 이벤트 핸들러를 사용하는 ImportantOptionDrawer에 누락된 "use client" 지시어를 다시 추가해야 하며, MatchingSliderButton의 접근성 속성(aria-valuenow) 계산 시 컨테이너 패딩을 고려하지 않아 발생하는 오차를 수정해야 합니다. 더불어 Drawer 핸들의 조건부 노출 로직 오류와 스타일 가이드에 따른 조건부 클래스 처리(cn 유틸리티 사용)에 대한 개선 사항이 지적되었습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement
Description
취미 선택 모달을 그리드 레이아웃으로 개선하고 이미지 추가
중요한 옵션 선택 섹션을 독립적인 드로어로 통합
슬라이더 버튼 텍스트에 shimmer 애니메이션 효과 적용
드로어 컴포넌트 기본값 및 스타일 조정
Diagram Walkthrough
File Walkthrough
ImportantOptionDrawer.tsx
Props 표준화 및 드로어 설정 개선app/matching/_components/ImportantOptionDrawer.tsx
"use client"지시문 제거isOpen→open,onClose→onOpenChange)onOpenChange(false)호출)DrawerContent에showHandle={false}추가MatchingHobbyBottomSheet.tsx
파일 삭제 및 기능 통합app/matching/_components/MatchingHobbyBottomSheet.tsx
MatchingHobbySection.tsx로 통합됨ScreenMatching.tsx
드로어 상태 관리 제거 및 Props 통합app/matching/_components/ScreenMatching.tsx
MatchingHobbyBottomSheet,ImportantBottomSheet임포트 제거isHobbyDrawerOpen,isImportantDrawerOpen)MatchingHobbySectionProps 변경 (onHobbyClick→onSelect)MatchingImportantOptionSectionProps 변경 (onClick→onSelect,selectedOption추가)MatchingHobbySection.tsx
취미 선택 UI를 그리드 레이아웃으로 개선app/matching/_components/MatchingHobbySection.tsx
/main/elec-bulb.png)onHobbyClick→onSelect)MatchingImportantOptionSection.tsx
중요 옵션 선택을 드로어로 통합app/matching/_components/MatchingImportantOptionSection.tsx
onClick→onSelect,selectedOption추가)MatchingSliderButton.tsx
슬라이더 텍스트 shimmer 애니메이션 적용app/matching/_components/MatchingSliderButton.tsx
shrink-0클래스 추가boxShadow값 수정 (inset 제거)boxShadow스타일 추가drawer.tsx
드로어 기본 설정 및 스타일 조정components/ui/drawer.tsx
showHandle기본값 변경 (true→false)80vh→96vh)mb-24,mt-24마진 값 제거after:hidden클래스 추가✨ Describe tool usage guide:
Overview:
The
describetool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.When commenting, to edit configurations related to the describe tool (
pr_descriptionsection), use the following template:With a configuration file, use the following template:
Enabling\disabling automation
meaning the
describetool will run automatically on every PR.the tool will replace every marker of the form
pr_agent:marker_namein the PR description with the relevant content, wheremarker_nameis one of the following:type: the PR type.summary: the PR summary.walkthrough: the PR walkthrough.diagram: the PR sequence diagram (if enabled).Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.
Custom labels
The default labels of the
describetool are quite generic: [Bug fix,Tests,Enhancement,Documentation,Other].If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:
Main topic:performance- pr_agent:The main topic of this PR is performanceNew endpoint- pr_agent:A new endpoint was added in this PRSQL query- pr_agent:A new SQL query was added in this PRDockerfile changes- pr_agent:The PR contains changes in the DockerfileThe list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.
Inline File Walkthrough 💎
For enhanced user experience, the
describetool can add file summaries directly to the "Files changed" tab in the PR page.This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs).
To enable inline file summary, set
pr_description.inline_file_summaryin the configuration file, possible values are:'table': File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab.true: A collapsable file comment with changes title and a changes summary for each file in the PR.false(default): File changes walkthrough will be added only to the "Conversation" tab.Utilizing extra instructions
The
describetool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.
Examples for extra instructions:
Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
More PR-Agent commands
See the describe usage page for a comprehensive guide on using this tool.