fix(protobuf_lark): replace bare assert with explicit raise ValueError#180
Open
SoundMatt wants to merge 1 commit into
Open
fix(protobuf_lark): replace bare assert with explicit raise ValueError#180SoundMatt wants to merge 1 commit into
SoundMatt wants to merge 1 commit into
Conversation
Two bare `assert(len(o.children) == 1)` calls in `process_enums` and `process_lark_tree` are converted to explicit `if … raise ValueError` checks. Bare asserts are silently disabled when Python runs with -O (optimized mode), making the parser accept malformed option nodes without any error. An explicit raise is always active and also provides a clearer diagnostic message. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
assert(len(o.children) == 1)calls inprocess_enumsandprocess_lark_treevalidate the shape of a parsed option node. Bareassertstatements are silently disabled when Python is run with the-Oflag (optimised mode, e.g. in some production deployments), meaning malformed nodes would pass through silently.Replace each with an explicit
if … raise ValueError(...)so the check is always active and produces a diagnostic message that includes the actual count.