Conversation
jnschrag
left a comment
There was a problem hiding this comment.
Thanks for taking a first pass at this - it's very much appreciated!
- Can you check your indentation? All items in the array should have the same indentation.
- If you could alphabetize these, that would be great! It'll make it easier on us as we adjust this list/need to easily scan them.
- Let's add the following items:
core/tablecore/htmlcore/videocore/embedcore-embed/twittercore-embed/youtubecore-embed/facebookcore-embed/soundcloudcore-embed/flickrcore-embed/vimeo
- Does the whitelist affect the blocks that are added by plugins? If it does, then we also need to make sure that the Jetpack slideshow & tiled gallery blocks are included
|
|
||
| ); | ||
| } | ||
| ?> No newline at end of file |
There was a problem hiding this comment.
Can you add a blank line at the end of the file? You also don't need the closing ?>
There was a problem hiding this comment.
I went ahead and added the additional blocks and reordered them alphabetically. Also fixed indentation.
As far as plugins being affected. It looks like the whitelist does affect those. I was trying to find what the jetpack slugs were called so I could add them to the list, but I haven't had any luck.
|
@dlousa92 Thanks for making these improvements. Re your comment about not being able to find Jetpack's blocks, you can take a look through their |
|
Thank you! So I have the correct names now, however they're not all popping up in the editor. 'jetpack/block-name' does work, as can be seen by the example 'jetpack/slideshow' I included in the code. However 'jetpack/tiled-gallery' or 'jetpack/carousel' do not show up. |
No description provided.