Add shear prandtl number variable #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When computing shear viscosity and diffusivity based on LMD94, no longer assume Prandtl number of one. Instead we add a Prandtl_shear variable (with a default value of 1) that users can configure similar to Ri_zero. Note that the output from the shear test has changed -- we now include both Mdiff and Tdiff for LMD and both PP tests. This first commit uses the default Prandtl_shear = 1, so Mdiff = Tdiff (= previous Tdiff value) in the LMD test. The next commit will change the test to use Prandtl_shear = 2.
Contributor
Author
|
@gustavo-marques ran MOM6 tests with KPP and verified
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing shear viscosity and diffusivity based on LMD94, no longer assume Prandtl number of one. Instead we add a Prandtl_shear variable (with a default value of 1) that users can configure similar to Ri_zero.
Note that the output from the shear test has changed -- we now include both Mdiff and Tdiff for LMD and both PP tests.
Fixes #104