Fix: Prevent unnecessary terminal spawning and respect TERMINAL env var#157
Open
Obsidian-Jackal wants to merge 1 commit intoCachyOS:developfrom
Open
Conversation
- Modified terminal-helper to check $TERMINAL and x-terminal-emulator first - Updated rootshell.sh to execute commands directly without spawning terminals - Modified gui.rs to detect simple systemctl commands and run them without terminals - Added comment to utils.rs clarifying pkexec behavior This fixes issues where authentication dialogs and simple operations like enabling/disabling systemd services were spawning unnecessary terminal windows. The changes ensure user terminal preferences are respected while preventing terminal spawning for operations that don't require user interaction.
vnepogodin
reviewed
Jan 23, 2026
|
|
||
| if is_simple_command { | ||
| // Run directly without spawning a terminal window | ||
| return utils::run_cmd(command.to_string(), escalate).map(|s| s.success()).unwrap_or(false); |
Member
There was a problem hiding this comment.
as of now it shouldn't spawn terminal window as it's using run_cmd
it also shouldn't spawn unnecessary auth prompts for systemctl operations as its handled by systemd already
Author
There was a problem hiding this comment.
That's not how the original flow of the code handled it. Are you sure you thoroughly tested how it was originally, before you made that comment?
Member
There was a problem hiding this comment.
Yeah, wasn't able to reproduce it either
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issues where authentication dialogs and simple operations like enabling/disabling systemd services were spawning unnecessary terminal windows. The changes ensure user terminal preferences are respected while preventing terminal spawning for operations that don't require user interaction.