Skip to content

Conversation

@abarz722
Copy link
Contributor

@abarz722 abarz722 commented Dec 4, 2025

fixes #3625

@tpurschke
Copy link
Contributor

two comments from Codex as reviewer:

  1. roles/lib/files/FWO.Data/Report/DeviceReport.cs (lines 38-44) – GetRuleListForDevice() now filters rulebase links by GatewayId and Removed != null and then compares NextRulebaseId, but the new getDevicesWithRulebaseLinks query only returns from_rule_id for active (removed = null) links. That leaves GatewayId/NextRulebaseId at their defaults and excludes all active links, so every call returns an empty rule list. Anything relying on this (e.g., app-rule filtering/highlighting) will see no rules for any device.
  2. roles/lib/files/FWO.Data/Modelling/ModellingVarianceResult.cs (lines 83-114) – FilterRulesForDev() maps rules to devices by matching rule.Id to rulebase_link.from_rule_id. For initial rulebases from_rule_id is null (only inline layers have it), so none of the normal rules will ever be attached to a device. The report builder still adds every device, but each ends up with an empty rule list, so “remaining/deleted rules” reports will come back empty even when rules exist.

@abarz722 abarz722 marked this pull request as ready for review December 9, 2025 15:37
@abarz722 abarz722 requested a review from tpurschke December 9, 2025 15:37
@abarz722
Copy link
Contributor Author

abarz722 commented Dec 9, 2025

Variance Analysis works at least a bit now, but proper tests have to be done with better data.

@tpurschke
Copy link
Contributor

@abarz722 can you pls. update your branch?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants