test(vault): enforce max-batch-size boundary (Fix #565)

contracts/revenue_pool/src/lib.rs

@@ -1,4 +1,5 @@
 #![no_std]
+#![warn(missing_docs)]
 
 use soroban_sdk::{
     contract, contracterror, contractimpl, contracttype, token, Address, BytesN, Env, Map, String, Symbol, Vec,

contracts/settlement/src/admin.rs

@@ -38,7 +38,10 @@ pub(crate) fn propose_balance_migration(env: &Env, caller: &Address, from: &Addr
     let amount: i128 = env
         .storage()
         .persistent()
-        .get(&StorageKey::DeveloperBalance(from.clone(), usdc_token.clone()))
+        .get(&StorageKey::DeveloperBalance(
+            from.clone(),
+            usdc_token.clone(),
+        ))
         .unwrap_or(0);
     if amount <= 0 {
         env.panic_with_error(SettlementError::NoDeveloperBalance);
@@ -76,11 +79,7 @@ pub(crate) fn execute_balance_migration(env: &Env, caller: &Address, from: &Addr
     let source_key = StorageKey::DeveloperBalance(from.clone(), usdc_token.clone());
     let destination_key = StorageKey::DeveloperBalance(migration.to.clone(), usdc_token.clone());
 
-    let source_balance: i128 = env
-        .storage()
-        .persistent()
-        .get(&source_key)
-        .unwrap_or(0);
+    let source_balance: i128 = env.storage().persistent().get(&source_key).unwrap_or(0);
     let new_source_balance = source_balance
         .checked_sub(migration.amount)
         .filter(|b| *b >= 0)

contracts/settlement/src/errors.rs

@@ -57,5 +57,7 @@ pub enum SettlementError {
     MigrationNotFound = 20,
     TimelockNotExpired = 21,
     MigrationBalanceChanged = 22,
-    MinimumBalanceRequired = 23,
+    OverDraft = 23,
+    InvalidClaimWindow = 24,
+    ClaimWindowClosed = 25,
 }

contracts/settlement/src/events.rs

@@ -209,7 +209,10 @@ mod tests {
     #[test]
     fn test_event_admin_broadcast_bytes() {
         let env = Env::default();
-        assert_eq!(event_admin_broadcast(&env), Symbol::new(&env, "admin_broadcast"));
+        assert_eq!(
+            event_admin_broadcast(&env),
+            Symbol::new(&env, "admin_broadcast")
+        );
     }
 
     #[test]