Add acquisition automation modes and fine-tune pipeline#397
Open
Add acquisition automation modes and fine-tune pipeline#397
Conversation
Properly rebased against main, preserving all existing functionality (can_expose wait, channel activate/deactivate, camerad ZMQ handler). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cfremling
force-pushed
the
feature/acq-automation-clean
branch
from
723cc0a to
527fe81
Compare
Latch ontarget=true when received; only clear on new target via reset_progress_only(). Prevents blinking caused by transient 1-second is_ontarget signal being repeatedly published as false. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
get_logical() was reading detrows/detcols (skip-adjusted) and osrows/oscols (binning-divided), causing set_image_size to shrink the image on every call. Use defrows/defcols and defosrows/defoscols (original config values) so repeated bin commands are idempotent. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MANUAL,AUTOMATIC,FULL_AUTOMATIC) controlled via the newacqmodecommand, enabling configurable hands-off target acquisitionngps_acqfine-acquisition algorithm in slicecamd (source detection, centroiding, TCS offsets, closed-loop acquisition) via C callback APIseq_progress_gui(X11+ZMQ) for real-time observation phase display (SLEW/SOLVE/FINE/OFFSET/EXPOSE)Files changed (19)
New files (4):
slicecamd/ngps_acq.c,common/ngps_acq_embed.h,utils/seq_progress_gui.cpp,common/message_keys.h,run/seq-progressModified files (14):
sequencerd/sequence.cpp,slicecamd/slicecam_interface.cpp,sequencerd/sequence.h,sequencerd/sequencer_server.cpp,slicecamd/slicecam_interface.h,Config/sequencerd.cfg.in,Config/slicecamd.cfg.in,acamd/acam_interface.cpp,utils/CMakeLists.txt,slicecamd/CMakeLists.txt,common/sequencerd_commands.h,common/slicecamd_commands.h,sequencerd/sequencerd.cpp,slicecamd/slicecam_server.cppTest plan
cmake .. && make -j$(nproc)— verify all 19 files compile cleanlyacqmodecommand accepts MANUAL/AUTOMATIC/FULL_AUTOMATIC🤖 Generated with Claude Code