Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds native macOS support to the Reorderable library and its demo application, enabling the project to run as a native macOS application alongside existing iOS targets. The implementation follows established multiplatform patterns in the codebase.
Changes:
- Added macOS targets (macosX64 and macosArm64) to both the library and demo app build configurations
- Created platform-specific macOS implementations for haptics (no-op) and application entry point
- Enabled experimental macOS support flag in Gradle properties
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| reorderable/build.gradle.kts | Added macosX64 and macosArm64 targets to the library's framework binaries configuration |
| gradle.properties | Enabled experimental macOS support with the org.jetbrains.compose.experimental.macos.enabled flag |
| demoApp/composeApp/src/macosMain/kotlin/sh/calvin/reorderable/demo/haptics.macos.kt | Implemented platform-specific haptics support with no-op behavior (consistent with JVM desktop) |
| demoApp/composeApp/src/macosMain/kotlin/main.kt | Created native macOS entry point using NSApplication APIs with proper window lifecycle management |
| demoApp/composeApp/build.gradle.kts | Added macOS targets with executable binaries and configured native application distribution as DMG |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
love it thank you! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.