You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixed weekly stats email math: install and fail are independent counters, so success/failure rates now use install / (install + fail) instead of the broken install - fail formula
Fixed monthly create-stats date window so the full previous UTC month is included (was cutting off almost the entire last day)
Fixed bundle:install_stats_24h trash counts by coercing Analytics Engine Float64 aggregates to numbers (string concat bug)
Release the deploy-email SQL claim for retry within 48h when installs are still too low / analytics lagged, so the email can actually send
Tightened get_weekly_stats to a true 7-day inclusive window (was 8 days)
Motivation (AI generated)
Weekly and monthly Capgo stats emails were reporting incorrect numbers, and bundle:install_stats_24h appeared to stop sending. Root cause was bad calculation/window logic plus Analytics Engine numeric values being left as strings and then concatenated, combined with permanently claiming install_stats_email_sent_at before a successful send.
Business Impact (AI generated)
Customers get trustworthy weekly/monthly activity emails again, and 24h post-deploy install emails can resume instead of being silently skipped after bad/empty analytics reads.
Test Plan (AI generated)
Unit tests for weekly rate math, monthly UTC range, install sum coercion, and deploy retry window (bun test:unit -- tests/cron-email-stats.unit.test.ts)
Lint changed files with eslint
After deploy of migration + workers: verify a weekly stats email shows success rate = installs / (installs + fails)
Verify monthly email includes bundles/publishes from the last day of the previous month
Verify a public-channel deploy with >1 installs in 24h receives bundle:install_stats_24h
Verify a deploy with temporarily empty analytics releases the claim and retries within 48h
Generated with AI
Summary by CodeRabbit
Bug Fixes
Corrected the weekly stats time window to consistently report exactly seven days.
Improved analytics numeric interpretation to ensure numeric aggregates are correctly converted for reporting.
Fixed monthly and deploy install stats date-range logic and aggregation accuracy.
Added safer retry behavior for eligible deploy stats emails, including clearer “not enough installs” results.
Improvements
Weekly and deploy cron emails now generate more accurate totals, rates, and labels.
Tests
Added unit coverage and backtests to prevent regressions in stats calculations and email formatting.
Weekly success/failure rates wrongly used install-fail instead of
install/(install+fail). Monthly stats truncated the last day of the
month. Deploy 24h emails could stringify Analytics Engine Float64
counts into trash values, then permanently skip sending after a
premature claim when installs looked too low.
Co-authored-by: Martin DONADIEU <martindonadieu@gmail.com>
Your recent review volume is higher than typical usage, so adaptive limits are currently applied.
Next review available in:16 minutes
Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).
How can I continue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.
How do review limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.
Cron email statistics now use centralized numeric, UTC date-range, aggregation, and retry helpers. Analytics Engine conversion supports additional numeric types, the weekly SQL window covers seven days, and unit tests cover the new utility behavior.
Typed helpers calculate weekly metrics, UTC month ranges, version install totals, and retry eligibility; the weekly SQL function uses an inclusive seven-day window and tests cover these behaviors.
Weekly and monthly email calculations use the new helpers, deploy installs use version matching aggregation, and eligible deploy claims can be released for retry.
No successful run was found on main (0e3cfe3) during the generation of this report, so c4b31f0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Not approving: Cursor Bugbot skipped (usage limit reached) and did not produce a clean review. Requesting human review for the stats-email calculation and SQL migration changes.
Sent by Cursor Approval Agent: Pull Request Approver
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Not approving: Cursor Bugbot skipped (usage limit reached), so automated review is incomplete, and this PR includes a SQL migration plus user-facing email stat fixes above the low-risk approval threshold. Assigned reviewers for human review.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@supabase/functions/_backend/triggers/cron_email.ts`:
- Around line 245-257: Handle query errors in the appVersions and deployHistory
fetches instead of discarding them. After each Supabase query, check its error
result and throw simpleError() when either query fails; only continue to monthly
activity processing when both queries succeed.
- Around line 362-379: Update the release-error branch in the deploy install
stats email retry flow to throw after cloudlogErr records releaseError, instead
of continuing to return the successful 200 response. Ensure the exception
propagates to the caller so the same cron job is retried while preserving the
existing success branch.
- Around line 211-217: Replace the weekNumber calculation near the
now/startOfYear logic with a true ISO-8601 week calculation, using UTC dates and
Thursday-based week-year boundaries so dates such as January 1, 2021 resolve to
week 53 of 2020. Keep the existing monthName calculation unchanged and ensure
the resulting metadata uses the computed ISO week number.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
Push a commit to this branch (recommended)
Create a new PR with the fixes
ℹ️ Review info⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3bd30dbf-4e1c-48c0-bcc6-dd9d564fa9ea
📥 Commits
Reviewing files that changed from the base of the PR and between 0e3cfe3 and e3b6052.
Add regression backtests proving weekly rates match admin
install/(install+fail), monthly windows include the last day,
24h install sums never string-concatenate, and "flawless" copy
is never used when failures are non-zero.
Co-authored-by: Martin DONADIEU <martindonadieu@gmail.com>
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Not approving: Cursor Bugbot skipped (usage limit reached), this PR exceeds the low-risk threshold (SQL migration plus user-facing email stat logic), and automated reviewers reported unresolved findings. Human reviewers are already assigned.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Not approving: Cursor Bugbot skipped (usage limit reached) and did not complete review. CodeRabbit and cubic also flagged unresolved cron email error-handling and stats issues; human review is still needed. Reviewers are already assigned.
Sent by Cursor Approval Agent: Pull Request Approver
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Not approving: Cursor Bugbot skipped (usage limit reached) and did not complete review. This PR exceeds the low-risk threshold (SQL migration plus user-facing email stat logic). Human reviewers are already assigned.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Not approving: Cursor Bugbot skipped (usage limit reached) and did not complete automated review. This PR exceeds the low-risk threshold (SQL migration plus user-facing email stat logic). Human reviewers are already assigned.
Sent by Cursor Approval Agent: Pull Request Approver External
Use "About one in ten" for the <=10% band and isolate the
get_weekly_stats window fixture under com.test.*.
Co-authored-by: Martin DONADIEU <martindonadieu@gmail.com>
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Not approving: Cursor Bugbot skipped (usage limit reached) and did not complete automated review. This PR exceeds the low-risk threshold (SQL migration plus user-facing email stat logic). Human reviewers are already assigned.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Not approving: Cursor Bugbot skipped (usage limit reached) and did not complete automated review. This PR exceeds the low-risk threshold (SQL migration plus user-facing email stat logic). Human reviewers are already assigned.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@supabase/tests/36_test_get_weekly_stats_window.sql`:
- Line 9: Wrap the long INSERT statements in the weekly stats SQL test,
including the referenced lines, so each line stays within SQLFluff’s
80-character LT05 limit. Preserve the existing columns, values, and SQL behavior
while formatting the statement across multiple lines.
In `@tests/cron-email-stats-backtest.unit.test.ts`:
- Line 61: Update all five test cases in this block, including the case titled
“never reproduces the old install-fail negative/wrong-rate bug across
production-like weeks,” to use the concurrent test variant. Keep their existing
fixtures, inputs, assertions, and test bodies unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
Push a commit to this branch (recommended)
Create a new PR with the fixes
ℹ️ Review info⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: eccd5fd7-ebb4-4e99-b195-a2f1d6a6cd29
📥 Commits
Reviewing files that changed from the base of the PR and between e3b6052 and 4d7c3e2.
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Not approving: Cursor Bugbot skipped (usage limit reached) and did not complete automated review. This PR exceeds the low-risk threshold (SQL migration plus user-facing email stat logic). Human reviewers are already assigned.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Risk: medium. Not approving: Cursor Bugbot skipped (usage limit reached) and did not complete automated review. This PR exceeds the low-risk threshold (SQL migration plus user-facing email stat logic). Human reviewers are already assigned.
Sent by Cursor Approval Agent: Pull Request Approver External
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Summary (AI generated)
installandfailare independent counters, so success/failure rates now useinstall / (install + fail)instead of the brokeninstall - failformulabundle:install_stats_24htrash counts by coercing Analytics EngineFloat64aggregates to numbers (string concat bug)get_weekly_statsto a true 7-day inclusive window (was 8 days)Motivation (AI generated)
Weekly and monthly Capgo stats emails were reporting incorrect numbers, and
bundle:install_stats_24happeared to stop sending. Root cause was bad calculation/window logic plus Analytics Engine numeric values being left as strings and then concatenated, combined with permanently claiminginstall_stats_email_sent_atbefore a successful send.Business Impact (AI generated)
Customers get trustworthy weekly/monthly activity emails again, and 24h post-deploy install emails can resume instead of being silently skipped after bad/empty analytics reads.
Test Plan (AI generated)
bun test:unit -- tests/cron-email-stats.unit.test.ts)bundle:install_stats_24hGenerated with AI
Summary by CodeRabbit
Bug Fixes
Improvements
Tests