[refactor] use as_crm_payload by default for serializer#10
Open
alexandrebk wants to merge 1 commit intomasterfrom
Open
[refactor] use as_crm_payload by default for serializer#10alexandrebk wants to merge 1 commit intomasterfrom
alexandrebk wants to merge 1 commit intomasterfrom
Conversation
alexandrebk
commented
Oct 3, 2025
| if serializer.respond_to?(:to_h) | ||
| serializer.to_h | ||
| else serializer.respond_to?(:as_crm_payload) | ||
| else |
Contributor
Author
There was a problem hiding this comment.
Si pas de méthode to_h alors on appel as_crm_payload
Comme il hérite de module Etlify::Serializer::BaseSerializer si la méthode est manquante ça va raise une erreur.
module Etlify
module Serializers
class BaseSerializer
attr_reader :record
def initialize(record)
@record = record
end
# @returns [Hash] serialized and stable payload
def as_crm_payload
raise NotImplementedError
end
end
end
end
AntoineBecquet
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8