metrics card on the data tab #2803
Conversation
There was a problem hiding this comment.
Pull request overview
This PR converts the ExperimentQueryResultComponent to a standalone component and integrates it into the new metrics data section card on the experiment details page. The changes enable metric data visualization by reusing the existing query result component in a new context.
- Converted
ExperimentQueryResultComponentfrom a module-declared component to a standalone component - Integrated the query result component into the experiment metrics data section
- Removed duplicate header text from the query result component template
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/projects/upgrade/src/app/features/dashboard/home/home.module.ts | Removed ExperimentQueryResultComponent from module declarations since it's now standalone |
| frontend/projects/upgrade/src/app/features/dashboard/home/components/experiment-query-result/experiment-query-result.component.ts | Converted component to standalone with required imports and updated selector |
| frontend/projects/upgrade/src/app/features/dashboard/home/components/experiment-query-result/experiment-query-result.component.html | Removed header text from template |
| frontend/projects/upgrade/src/app/features/dashboard/experiments/pages/experiment-details-page/experiment-details-page-content/experiment-metrics-data-section-card/experiment-metrics-data/experiment-metrics-data.component.ts | Added experiment input and imported the query result component |
| frontend/projects/upgrade/src/app/features/dashboard/experiments/pages/experiment-details-page/experiment-details-page-content/experiment-metrics-data-section-card/experiment-metrics-data/experiment-metrics-data.component.html | Replaced placeholder text with query result component |
| frontend/projects/upgrade/src/app/features/dashboard/experiments/pages/experiment-details-page/experiment-details-page-content/experiment-metrics-data-section-card/experiment-metrics-data-section-card.component.html | Added experiment input binding to metrics data component |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...tures/dashboard/home/components/experiment-query-result/experiment-query-result.component.ts
Show resolved
Hide resolved
...iment-metrics-data-section-card/experiment-metrics-data/experiment-metrics-data.component.ts
Show resolved
Hide resolved
|
I think this may need to make sure the text is left-aligned along same line as the section-card header text: figma: currently it's indented further inward: |
|
this looks like it's in working order, sans the comments i made in slack that are probably not for this PR to worry about I think we should move this component from where it is with older stuff into the new structure though, maybe i can share a branch with what i mean, easier than writing it out... |
|
so that branch is a one-commit example of the same thing you've done, just tucking the old component under the card. except it also gets rid of the experiment-metric-data component because it was just a wrapper for the old component, and a few files that are blank or not developed. i tested this out and it works the same. 
|
@danoswaltCL Should we do the same with the enrollment components then. That was on an earlier pr that was already approved and merged. |
No description provided.