spec/support/database: support running postgres in docker#502
Open
kyrofa wants to merge 1 commit intoCasecommons:masterfrom
Open
spec/support/database: support running postgres in docker#502kyrofa wants to merge 1 commit intoCasecommons:masterfrom
kyrofa wants to merge 1 commit intoCasecommons:masterfrom
Conversation
Add a docker-compose.yml file that sets up a PostgreSQL image configured to run pg_search's test suite. Add support to `spec/support/database` for using that container's PostgreSQL instance to run the test suite by simply checking if the `DOCKER` environment variable is set. Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd rather not install postgres, its extensions, or configure test databases (and setup access to them) on my development machine. I'd much rather use a Docker container dedicated to that task that I can destroy as I see fit, which keeps my development environment clean. This trivial PR adds support for that workflow by adding a
docker-compose.ymlfile that sets up a PostgreSQL image configured to run pg_search's test suite. It also adds support tospec/support/databasefor using that container's PostgreSQL instance to run the test suite by simply checking if theDOCKERenvironment variable is set.