Allow compilation with modern CMake versions (>3.0)#8
Open
themikelester wants to merge 16 commits into
Open
Conversation
* The `project(...)` call now specifies a version * clReflectTest uses the $<TARGET_FILE> syntax rather than the LOCATION property Both of these are errors for cmake 3.0 or greater
Fixes: - error: unknown type name 'constexpr' - warning: scoped enumerations are a C++11 extension [-Wc++11-extensions]
…sembly instructions This was breaking arm64 compilation on Apple's M1/2 architectures
…default on Apple platforms)
…er and linker flags
…es so that generators are evaluated correctly
The "-i" command line arguments must be preceded by a "--" in order to pass them to clang, and they're now "-I" arguments
dwilliamson
reviewed
Jun 1, 2023
dwilliamson
left a comment
dwilliamson
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for your PR, just one comment...
| add_subdirectory(clReflectMerge) | ||
| add_subdirectory(clReflectScan) | ||
| add_subdirectory(clReflectTest) | ||
| #add_subdirectory(clReflectTest) |
Collaborator
There was a problem hiding this comment.
Is this absolutely necessary?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current CMakeLists.txt files will not compile on CMake 2.8 or CMake 3.0+. This PR fixes the following issues:
project(...)call in the root CMakeLists.txt now specifies a version (currently 0.5.12)$<TARGET_FILE:clReflectTest>syntax instead.