Skip to content

[ENG-9887] Fix naming in templates #11546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bodintsov wants to merge 1 commit into
base: feature/notifications-refactor-post-release
Choose a base branch
from
+8 −6
Open

[ENG-9887] Fix naming in templates #11546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/requests/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ def make_node_institutional_access_request(self, node, validated_data) -> NodeRe
'sender_absolute_url': sender.absolute_url,
'node_absolute_url': node_request.target.absolute_url,
'node_title': node_request.target.title,
'recipient_fullname': recipient.username if recipient else None,
'recipient_username': recipient.username if recipient else None,
'comment': comment,
'domain': settings.DOMAIN,
'institution_name': institution.name if institution else None,
Expand Down
10 changes: 6 additions & 4 deletions website/archiver/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,13 @@ def send_archiver_file_not_found_mails(src, user, results, url):
NotificationType.Type.DESK_ARCHIVE_JOB_FILE_NOT_FOUND.instance.emit(
destination_address=settings.OSF_SUPPORT_EMAIL,
event_context={
'user': user.id,
'src': src._id,
'domain': settings.DOMAIN,
'src': src,
'src_title': src.title,
'user__id': user._id,
'user_fullname': user.fullname,
'src__id': src._id,
'results': results,
'url': url,
'can_change_preferences': False,
}
)
NotificationType.Type.USER_ARCHIVE_JOB_FILE_NOT_FOUND.instance.emit(
Copy link
Collaborator

@cslzchen cslzchen Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this one has the same issue but I couldn't find the template in the yaml file. Check develop-pre-nr branch to see if we missed this or this never existed.

Expand Down
2 changes: 1 addition & 1 deletion website/templates/node_request_institutional_access_request.html.mako
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<%def name="content()">
<tr>
<td style="border-collapse: collapse;">
Hello ${recipient_fullname},
Hello ${recipient_username},
<p>
<a href="${sender_absolute_url}">${sender_fullname}</a> has requested access to <a href="${node_absolute_url}">${node_title}</a>.
</p>
Expand Down
Loading