Skip to content

[hotfix/26.1.6] [ENG-10041] Mark notifications that failed to render as fake sent #11550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cslzchen merged 1 commit into from
Jan 14, 2026
Merged

[hotfix/26.1.6] [ENG-10041] Mark notifications that failed to render as fake sent #11550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions notifications/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ def safe_render_notification(notifications, email_task):
email_task.error_message = f'Error rendering notification {notification.id}: {str(e)} \n'
email_task.save()
failed_notifications.append(notification.id)
# Mark notifications that failed to render as fake sent
# Use 1000/12/31 to distinguish itself from another type of fake sent 1000/1/1
log_message(f'Error rendering notification, mark as fake sent: [notification_id={notification.id}]')
notification.sent = datetime(1000, 12, 31)
notification.save()
continue

rendered_notifications.append(rendered)
Expand Down
Loading