Skip to content

Create new CesiumImage library for image-related code#1388

Open
j9liu wants to merge 5 commits into
mainfrom
image-library
Open

Create new CesiumImage library for image-related code#1388
j9liu wants to merge 5 commits into
mainfrom
image-library

Conversation

@j9liu
Copy link
Copy Markdown
Contributor

@j9liu j9liu commented Jun 4, 2026

Description

This creates a new CesiumImage library to hold:

  • ImageAsset
  • ImageDecoder
  • Ktx2TranscodeTargets
  • ImageManipulation

This is some tech debt I ran into that prevented me from using functions from CesiumGltfContent in CesiumGltfReader. I figure I would rip the band-aid off and make this change since it's relatively straightforward.

Issue number or link

Closes #221

Author checklist

  • I have submitted a Contributor License Agreement (only needed once).
  • I have done a full self-review of my code.
  • I have updated CHANGES.md with a short summary of my change (for user-facing changes).
  • I have added or updated unit tests to ensure consistent code coverage as necessary.
  • I have updated the documentation as necessary.

Testing plan

See:

Reviewer checklist

Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author.

As you review, please go through the checklist below:

  • Review and run all parts of the test plan on this branch and verify it matches expectations.
    • If the issue is a bug please make sure you can reproduce the bug in the main branch and then checkout this branch to make sure it actually solved the issue.
  • Review the code and make sure you do not have any remaining questions or concerns. You should understand the code change and the chosen approach. If you are not confident or have doubts about the code, please do not hesitate to ask questions.
  • Review the unit tests and make sure there are no missing tests or edge cases.
  • Review documentation changes and updates to CHANGES.md to make sure they accurately cover the work in this PR.
  • Verify that the Contributor License Agreement has been submitted, if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move ImageAsset, ImageDecoder, and other related classes to a new library

1 participant