Pipeline changes for better handling of failures#22
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
…as additional predicate
There was a problem hiding this comment.
Pull request overview
This PR updates several inference/utility scripts to better handle validation failures, improve c3p comparison ergonomics, and add tooling for inspecting/adjusting learned-definition pickles.
Changes:
- Add a
set-learn-falseCLI subcommand to mark a learned/additional definition aslearn_success=Falsein the learned-definitions pickle. - Make
compare_with_c3p.pyrobust to missing learned definitions and provide a default--c3p-jsonpath. - Adjust validator behavior to continue past per-class validation errors, and refine recursive learning behavior by having
_learn()return a boolean.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
nl_2_fol/inference/utils/show_learned_content.py |
Adds a new pickle-editing command (set-learn-false) for flipping learn_success flags. |
nl_2_fol/inference/utils/compare_with_c3p.py |
Avoids KeyErrors when learned definitions are missing and adds a default c3p JSON path. |
nl_2_fol/inference/utils/calculate_c3p_stats.py |
Introduces a new script to compute and print F1 distribution statistics from c3p_trust.json. |
nl_2_fol/inference/learner/validator.py |
Continues validation despite exceptions and summarizes the number of failures. |
nl_2_fol/inference/learner/learn_definitions.py |
Makes _learn() return a success boolean and uses it when handling missing predicates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.