Skip to content

Fix review comments: type hints, error handling, and documentation#152

Merged
aditya0by0 merged 2 commits intofeature/general_pred_pipelinefrom
copilot/sub-pr-148
Feb 17, 2026
Merged

Fix review comments: type hints, error handling, and documentation#152
aditya0by0 merged 2 commits intofeature/general_pred_pipelinefrom
copilot/sub-pr-148

Conversation

Copy link

Copilot AI commented Feb 17, 2026

Addresses 8 review comments from PR #148 covering type annotations, error handling patterns, and documentation consistency.

Changes

chebai/preprocessing/migration/migrate_checkpoints.py

  • Fixed argument count validation (< 2< 3 for two required arguments)
  • Corrected script name in usage message (modify_checkpoints.pymigrate_checkpoints.py)
  • Fixed docstring typo

chebai/result/prediction.py

  • Replaced unnecessary try-except with None check after dict.get()
  • Fixed typo: "piplines" → "pipelines"

chebai/preprocessing/datasets/base.py

  • Updated model_hparams type documentation from Optional[dict] to dict to match implementation
  • Added type annotation: idxidx: int

README.md

  • Fixed logger name inconsistency in example command (chebi50_bce_unweightedchebi50_bce_weighted to match bce_weighted.yml criterion)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: aditya0by0 <65857172+aditya0by0@users.noreply.github.com>
Copilot AI changed the title [WIP] Generalize prediction pipeline for Lightning CLI models Fix review comments: type hints, error handling, and documentation Feb 17, 2026
Copilot AI requested a review from aditya0by0 February 17, 2026 19:42
@aditya0by0 aditya0by0 marked this pull request as ready for review February 17, 2026 19:43
@aditya0by0 aditya0by0 merged commit 679a5cb into feature/general_pred_pipeline Feb 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants