Fix review comments: type hints, error handling, and documentation#152
Merged
aditya0by0 merged 2 commits intofeature/general_pred_pipelinefrom Feb 17, 2026
Merged
Fix review comments: type hints, error handling, and documentation#152aditya0by0 merged 2 commits intofeature/general_pred_pipelinefrom
aditya0by0 merged 2 commits intofeature/general_pred_pipelinefrom
Conversation
Co-authored-by: aditya0by0 <65857172+aditya0by0@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Generalize prediction pipeline for Lightning CLI models
Fix review comments: type hints, error handling, and documentation
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses 8 review comments from PR #148 covering type annotations, error handling patterns, and documentation consistency.
Changes
chebai/preprocessing/migration/migrate_checkpoints.py
< 2→< 3for two required arguments)modify_checkpoints.py→migrate_checkpoints.py)chebai/result/prediction.py
dict.get()chebai/preprocessing/datasets/base.py
model_hparamstype documentation fromOptional[dict]todictto match implementationidx→idx: intREADME.md
chebi50_bce_unweighted→chebi50_bce_weightedto matchbce_weighted.ymlcriterion)💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.