add top class option for chebi graph, set molecular entity as default#9
Merged
sfluegel05 merged 2 commits intodevfrom May 7, 2026
Merged
add top class option for chebi graph, set molecular entity as default#9sfluegel05 merged 2 commits intodevfrom
sfluegel05 merged 2 commits intodevfrom
Conversation
Contributor
Author
|
@copilot unittests are failing, fix |
Agent-Logs-Url: https://github.com/ChEB-AI/python-chebi-utils/sessions/5b167856-711a-4140-86d3-17827d69a2d7 Co-authored-by: sfluegel05 <43573433+sfluegel05@users.noreply.github.com>
Contributor
Fixed in a464207. I investigated the CI failures, reproduced them locally, and updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the ChEBI graph includes all classes in ChEBI, including roles, chemical entities (which include atoms, chemical substances, groups and molecular entities) and subatomic particles.
As discussed in the March 26 Strontex meeting, it does not make sense for our models to learn the classification of subatomic particles, atoms, chemical substances or groups. Roles are also a different classification task.
Therefore, I changed the default ChEBI graph to be the subgraph of molecular entity (excluding molecular entity itself). By setting the top class, one can get other graphs if needed.