Dynamic imports - for model-specific packages#12
Merged
sfluegel05 merged 11 commits intodevfrom Aug 11, 2025
Merged
Conversation
Contributor
|
Looks good. I had some trouble with reformatting (I used the github web interface to resolve mere conflicts which was a mistake), but that should be resolved now. Also, I like the trick with putting type hints in quotation marks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note On Dynamic Imports:
Even if you write import package inside a method that’s called 100 times, Python’s import system caches it.
Because of Python’s internal import caching mechanism.
The first time, Python loads torch from disk and stores it in sys.modules.
Every subsequent import torch, even if it appears in a loop or method, simply reuses the already-loaded module.
So performance-wise, it’s almost free after the first import.
Check documentation here: https://docs.python.org/3/reference/import.html#the-module-cache
https://docs.python.org/3/faq/programming.html#why-are-modules-imported-multiple-times