-
Notifications
You must be signed in to change notification settings - Fork 20
Make processor enabled runtime #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make processor enabled runtime #192
Conversation
|
Do we have to remove the preference based switch |
|
Hmmm, yes
Hmmm, yes. I wonder what to do about reboots. I'll set it so the properties manages the persisted value at least. |
d2195e3 to
9f85a46
Compare
src/main/java/org/phoebus/channelfinder/processors/ChannelProcessorManager.java
Outdated
Show resolved
Hide resolved
src/main/java/org/phoebus/channelfinder/processors/ChannelProcessorManager.java
Show resolved
Hide resolved
src/main/java/org/phoebus/channelfinder/processors/aa/AAChannelProcessor.java
Outdated
Show resolved
Hide resolved
georgweiss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the new endpoints covered by unit tests? Asking as I usually find it useful to add unit tests to be able to capture minor changes, e.g. change name or method of endpoint.
b5c014b to
d471b19
Compare
Yes see d471b19 |
d471b19 to
701b713
Compare
Added a test for the Manager (equivalent to resource in olog) |
src/test/java/org/phoebus/channelfinder/processors/ChannelProcessorServiceTest.java
Outdated
Show resolved
Hide resolved
|
anderslindho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM



No description provided.