Skip to content

Conversation

@jacomago
Copy link
Contributor

No description provided.

@jacomago jacomago marked this pull request as draft October 28, 2025 15:08
@shroffk
Copy link
Collaborator

shroffk commented Oct 29, 2025

Do we have to remove the preference based switch
I see the benefit in having a end point to enable/disable this processor but it is also nice to be able to manage this using preferences in a more static setup

@jacomago
Copy link
Contributor Author

jacomago commented Nov 3, 2025

Hmmm, yes

Do we have to remove the preference based switch I see the benefit in having a end point to enable/disable this processor but it is also nice to be able to manage this using preferences in a more static setup

Hmmm, yes. I wonder what to do about reboots. I'll set it so the properties manages the persisted value at least.

@jacomago jacomago force-pushed the runtime-processor-config branch 2 times, most recently from d2195e3 to 9f85a46 Compare November 3, 2025 11:46
@jacomago jacomago self-assigned this Nov 3, 2025
@jacomago jacomago marked this pull request as ready for review November 3, 2025 11:46
Copy link
Collaborator

@georgweiss georgweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the new endpoints covered by unit tests? Asking as I usually find it useful to add unit tests to be able to capture minor changes, e.g. change name or method of endpoint.

@jacomago jacomago force-pushed the runtime-processor-config branch 2 times, most recently from b5c014b to d471b19 Compare November 5, 2025 15:13
@jacomago
Copy link
Contributor Author

jacomago commented Nov 5, 2025

Are the new endpoints covered by unit tests? Asking as I usually find it useful to add unit tests to be able to capture minor changes, e.g. change name or method of endpoint.

Yes see d471b19

@jacomago jacomago force-pushed the runtime-processor-config branch from d471b19 to 701b713 Compare November 6, 2025 14:57
@jacomago
Copy link
Contributor Author

jacomago commented Nov 6, 2025

Are the new endpoints covered by unit tests? Asking as I usually find it useful to add unit tests to be able to capture minor changes, e.g. change name or method of endpoint.

Added a test for the Manager (equivalent to resource in olog)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2025

Copy link
Contributor

@anderslindho anderslindho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shroffk shroffk merged commit 9f93d76 into ChannelFinder:master Nov 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants