Change read check mechanism. Initial commit. #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve issue #4 .
Now we checking on unsafe EOF comparison, instead of preventing every type cast from
ReadInttobyteorchar. (As the only unsafe operation is comparing convertedbyteorcharto EOF value-1, the type cast itself is safe in terms of avoiding prematurely exit from loop or stuck into infinite loop).Reason of removing tests:
post-condition: Original post-condition is for propagating the EOF value check in a separate method, to determine if the type cast in the caller is safe. The new mechanism doesn't prevent type cast anymore, therefore, we don't need this post-condition in the new way.
binaryOpRefine: this is a TODO. Currently new way only checking on
eqaulToandnotEqualTo, should add checking on range checking (e.g. forlessThan: should prevent unsafe comparison like@NRI< 0).teamed-quiz: this is a realWorld example for
binaryOpRefine. Also a TODO here.