feat: add MediaElement MVP control and initial tests#9
feat: add MediaElement MVP control and initial tests#9lustsazeus-lab wants to merge 2 commits intoChevalier12:masterfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22f1794215
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <MediaElement xmlns=\"urn:inkkslinger-ui\" | ||
| Source=\"https://example.com/demo.mp4\" | ||
| LoadedBehavior=\"Manual\" /> |
There was a problem hiding this comment.
Remove escaped quotes from raw XAML literal
This test uses a C# raw string ("""), so \" is emitted literally into the XML; that produces markup like xmlns=\"urn:inkkslinger-ui\", which is not well-formed and will fail in XamlLoader.LoadFromString when it calls XDocument.Parse. As written, XamlLoader_CanInstantiate_MediaElement will throw before assertions and won't validate MediaElement instantiation.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed in commit 174b0a8 — removed escaped quotes in the C# raw string literal so the test now emits valid XML for XamlLoader.LoadFromString.
21856fd to
8a233f1
Compare
dc68d7e to
1cc7eb5
Compare
174b0a8 to
786b946
Compare
786b946 to
c4100fe
Compare
Summary
Notes
Closes #5