Run on background#33
Conversation
SynthNibbler
left a comment
There was a problem hiding this comment.
The permissions popups look very clean and make sense to ask the user for permissions before forcing the features. The permissions are separated and chained one after another so the user can set these up quickly at the start and then continue using the app. This flow makes sense. The code is well commented with descriptions of what the code is doing.
This PR appears to be combining a feature addition with a large refactoring of most of the project. It is also bundled with some unrelated maintenance changes, such as two python scripts. One of these scripts is described as locating android/settings.gradle for fixing a Notifee build error, but it is unclear why this solution was needed. The other python script is deleting some dependencies and editing the .gitignore file.
After running the app to test the behavior, it has overlapping popups when creating an alarm, this can be replicated consistently. When closing the app it stalls for a few seconds with a "saving state" popup before actually closing.
Before this gets merged the feature related code should be separated from the maintenance code. The overlapping popups would also need to be fixed.
4377a5a to
53aa968
Compare
|
This is a much tighter PR with a better focus of what features are requesting to be merged, it is still several features packaged though so not all features have been reviewed yet. I did test 3 of them so far, creating a new batch and the interval alarms triggering and lockscreen alerts. This version has a bug with the battery optimization permissions. It offers to update settings but triggers the notification on each "Create Alarm" no matter what the battery optimization permission is set to. I included a video attachment to demonstrate this behavior. The Notification for the alarms works, it does notify on each interval for the set, but it only pings like a notification, it does not ring an alarm. The behavior for the alarm triggering a pop up and sound until dismissed is removed. The alarm needs to ring until the user dismisses it, not just a ping like a text message. They do correctly work if the app is in the background. The battery optimization flow needs to be fixed so the user can set it or skip it and it does not trigger again. BatteryOpt_loop.mp4 |
SynthNibbler
left a comment
There was a problem hiding this comment.
Looks great! New features seem to work as intended and works well consistently.
No description provided.