Test new folder structure with workflows#4
Conversation
… refactoring/change-folder-layout
There was a problem hiding this comment.
Pull Request Overview
This PR restructures the project folder hierarchy and migrates from xUnit to TUnit testing framework to prepare for new GitHub workflows. The changes organize source code into src/ and test code into tests/ directories while updating the build configuration to support the new structure.
Key changes include:
- Migration from xUnit to TUnit testing framework with updated assertions
- Reorganization of project structure with
src/andtests/directories - Introduction of Directory.Build.props files for centralized configuration
Reviewed Changes
Copilot reviewed 21 out of 117 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/TvdbClient.Tests/TvdbClient.Tests.csproj | New test project configuration for TUnit framework |
| tests/TvdbClient.Tests/Provider/TvdbTokenProviderUnitTests.cs | Migrated test from xUnit to TUnit attributes and removed logging dependencies |
| tests/TvdbClient.Tests/Converters/*.cs | New converter test files using TUnit framework and Shouldly assertions |
| tests/Directory.Build.props | Centralized test project configuration with TUnit packages |
| src/TvdbClient/TvdbClient.csproj | Simplified project file with common properties moved to Directory.Build.props |
| src/Directory.Build.props | Centralized source project configuration with package metadata |
| .github/workflows/*.yml | Updated workflow paths and added new release/coverage workflows |
| - name: Setup .NET | ||
| uses: actions/setup-dotnet@v4 | ||
| with: | ||
| dotnet-version: '8.x' # Adjust to your .NET version |
There was a problem hiding this comment.
The .NET version comment indicates '8.x' but the project targets net9.0. Update the dotnet-version to '9.x' to match the project's target framework.
| dotnet-version: '8.x' # Adjust to your .NET version | |
| dotnet-version: '9.x' # Adjust to your .NET version |
| - name: Setup .NET | ||
| uses: actions/setup-dotnet@v4 | ||
| with: | ||
| dotnet-version: '8.x' # Adjust to your .NET version |
There was a problem hiding this comment.
The .NET version comment indicates '8.x' but the project targets net9.0. Update the dotnet-version to '9.x' to match the project's target framework.
| dotnet-version: '8.x' # Adjust to your .NET version | |
| dotnet-version: '9.x' # Adjust to your .NET version |
| - name: Setup .NET | ||
| uses: actions/setup-dotnet@v4 | ||
| with: | ||
| dotnet-version: '8.x' |
There was a problem hiding this comment.
The .NET version should be '9.x' to match the project's target framework (net9.0).
| dotnet-version: '8.x' | |
| dotnet-version: '9.x' |
| echo "## NuGet Package" >> release_notes.md | ||
| echo "This release is available on NuGet:" >> release_notes.md | ||
| echo '```' >> release_notes.md | ||
| echo "dotnet add package YourPackageName --version ${{ needs.build-and-test.outputs.version }}" >> release_notes.md |
There was a problem hiding this comment.
The placeholder 'YourPackageName' should be replaced with the actual package name 'TvdbClient' based on the project structure.
| echo "dotnet add package YourPackageName --version ${{ needs.build-and-test.outputs.version }}" >> release_notes.md | |
| echo "dotnet add package TvdbClient --version ${{ needs.build-and-test.outputs.version }}" >> release_notes.md |
merging back into master in order to get new github workflows to run