Compatibility update#5
Open
tanxpyox wants to merge 14 commits intoChristopherLucas:CRAN_compatiblefrom
Open
Conversation
make extract.features.R compatible with hmm and llh add an option to call standardizeFeatures with extractFeatures
This reverts commit 96eeb33.
allows extraction of raw_data and timestamps without affecting the functionality of hmm / llh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes:
extractFeaturesandextractFeatureto suppress inclusion ofraw_dataandtimestampsin the output feature matrices. Suppression is on by default.standardizetoextractFeatures. When true, it standardizes the feature matrices before output. (Note: standardizeFeatures is not an exported method.)raw_dataandtimestampsto root to avoid compatibility issues with functions that only take features as matrices or lists of matrices$fileattribute to theextractFeaturesoutput for easy access of metadata. Currently contains:$fname: vector of filenames corresponding to the sources of the feature matrices$duration: vector containing the row numbers of the feature matrices - for assigning fold in cross-validation model training.Misc changes:
hmm.Randllh.Rso that they work for matrices created after R 4.0.0llh()so that it can be used to evaluate model performance.hmm.R: when called withverbose = 0, stdout messages fromstandardizeFeatures(whenstandardize = T) and 'failure to converge by max iter' warnings are suppressed.