Conversation
Releasing v25.3
Releasing v25.4
Releasing v25.6
Releasing v25.7
Releasing v25.8
Release 25.10
Release 25.11
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d9a26c0ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @ssh -q $(PROD_USER) 'test -e $(STAGING_PKGS)/$(PKG_NAME) || mkdir $(STAGING_PKGS)/$(PKG_NAME)' | ||
| @scp $(DIST_DIR)/* $(PROD_USER):$(STAGING_PKGS)/$(PKG_NAME)/ |
There was a problem hiding this comment.
The new distribute_staging target uses $(PROD_USER) and $(STAGING_PKGS) without defining defaults or checking that they are set, and this commit also removed the previous top-level deploy variable defaults. In a normal local run (no extra env vars), these expand to empty strings and produce invalid commands like ssh -q ... / scp ... :/unicon.plugins/, so staging distribution fails (or can target an unintended path) before any package is copied.
Useful? React with 👍 / 👎.
9 participants
Automated PR to merge release branch
release_26.2intodev.