Don't fail XLSX mimetype on Windows for py3.14#1020
Merged
anoto-moniz merged 1 commit intorelease/v4.0from Feb 19, 2026
Merged
Conversation
Python 3.14 expanded the mimetypes recognized by the mimetypes module, including the ECMA-376 spec, which defines the XLSX type. Directly supporting it rather than relying on the underlying system (i.e. Windows registry) to capture it seems to guarantee its presence.
anoto-moniz
force-pushed
the
fix-py314-windows-xslx
branch
from
95bb105 to
133e5c3
Compare
anoto-moniz
changed the title
kroenlein
approved these changes
Feb 19, 2026
| "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet", | ||
| marks=pytest.mark.xfail( | ||
| platform.system() == "Windows", | ||
| platform.system() == "Windows" and PYTHON_VERSION_TUPLE <= (3, 13), |
Collaborator
There was a problem hiding this comment.
I'd think a Version object would make this comparison cleaner, but if it works, cool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.14 expanded the mimetypes recognized by the mimetypes module, including the ECMA-376 spec, which defines the XLSX type. Directly supporting it rather than relying on the underlying system (i.e. Windows registry) to capture it seems to guarantee its presence.
PR Type:
Adherence to team decisions