[jjb9707] Fix tiered rate limiting for authenticated vs anonymous (#200)#4890
Closed
jjb9707 wants to merge 1 commit into
Closed
[jjb9707] Fix tiered rate limiting for authenticated vs anonymous (#200)#4890jjb9707 wants to merge 1 commit into
jjb9707 wants to merge 1 commit into
Conversation
- Three tiers: anonymous (60/min), authenticated (300/min), premium (1000/min) - Sliding window algorithm (replaces buggy fixed window) - Auth determined from JWT payload roles - Response headers: X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset - 429 response with Retry-After header - Health endpoint exempt from rate limiting - Comprehensive tests for all tiers, headers, and edge cases Closes ClankerNation#200
|
Unfortunately the changes in this PR didn't fully resolve the issue. Please rework your solution and submit a new pull request within 2 hours. Make sure to review the acceptance criteria in the linked issue and verify all conditions are met before resubmitting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements three-tier rate limiting that differentiates anonymous, authenticated, and premium users.
Changes (
api/middleware/ratelimit.py)Three-tier limits:
Key improvements over original:
premiumrole = premiumX-RateLimit-Limit,X-RateLimit-Remaining,X-RateLimit-Resetheaders on every responseRetry-AfterheaderTests (
test/test_ratelimit.py)14 comprehensive tests covering:
/claim #200