Skip to content

Enhance RPM audit functionality and improve evidence file uploads#58

Merged
naveensrinivasan merged 1 commit into
mainfrom
naveen/audit-json-rpm-packages
May 6, 2026
Merged

Enhance RPM audit functionality and improve evidence file uploads#58
naveensrinivasan merged 1 commit into
mainfrom
naveen/audit-json-rpm-packages

Conversation

@naveensrinivasan

Copy link
Copy Markdown
Member
  • Added workspace directory resolution for RPM audit uploads in packagePromote.
  • Updated UploadPromotionEvidenceFiles to accept a workspace directory parameter for resolving relative paths to sibling RPM audit JSON files.
  • Implemented rpmAuditPathsFromTestResults to discover and append sibling audit files based on test results.
  • Introduced new tests for loading and writing RPM audit records, ensuring proper handling of audit data alongside built RPMs.

- Added workspace directory resolution for RPM audit uploads in `packagePromote`.
- Updated `UploadPromotionEvidenceFiles` to accept a workspace directory parameter for resolving relative paths to sibling RPM audit JSON files.
- Implemented `rpmAuditPathsFromTestResults` to discover and append sibling audit files based on test results.
- Introduced new tests for loading and writing RPM audit records, ensuring proper handling of audit data alongside built RPMs.
@naveensrinivasan naveensrinivasan merged commit cefe427 into main May 6, 2026
3 of 4 checks passed
@naveensrinivasan naveensrinivasan deleted the naveen/audit-json-rpm-packages branch May 6, 2026 13:47
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 47.01493% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.35%. Comparing base (5ca5bed) to head (3ca83e5).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/packageexec/execute.go 0.00% 36 Missing ⚠️
internal/packageexec/audit.go 64.28% 23 Missing and 12 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   47.02%   47.35%   +0.33%     
==========================================
  Files          49       50       +1     
  Lines        7318     7414      +96     
==========================================
+ Hits         3441     3511      +70     
- Misses       3489     3501      +12     
- Partials      388      402      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants