Fix RPM audit files not appearing in index.json#59
Merged
Conversation
The root cause was that the toPlatformArtifact function in the promotion flow only set the Binary field but not the Audit field for RPM packages. When package promotion ran, it would upload the RPM and its audit file to GitHub, but the database artifacts JSON only recorded the Binary, not the Audit. This caused the audit to be null in the database and missing from the generated index.json. Changes: - Modified toPlatformArtifact in internal/promotion/promote.go to set the Audit field for RPM targets with the audit filename and URL - Added tests for RPM audit file handling in release and promotion Fixes the issue where OSPO-nodejs-*.rpm.audit.json files were uploaded to GitHub releases but not reflected in index.json.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 47.35% 47.39% +0.04%
==========================================
Files 50 50
Lines 7414 7420 +6
==========================================
+ Hits 3511 3517 +6
Misses 3501 3501
Partials 402 402 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause was that the toPlatformArtifact function in the promotion flow only set the Binary field but not the Audit field for RPM packages. When package promotion ran, it would upload the RPM and its audit file to GitHub, but the database artifacts JSON only recorded the Binary, not the Audit. This caused the audit to be null in the database and missing from the generated index.json.
Changes:
Fixes the issue where OSPO-nodejs-*.rpm.audit.json files were uploaded to GitHub releases but not reflected in index.json.