Add support for all remaining APS and alert payload keys in Notification.Builder #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended the Notification.Builder to support sound dictionary, additional APS headers, and alert dictionary keys for richer APNS payload customization. This includes methods for critical sound, volume, localization keys, thread ID, content state, and more.
Added unit tests to verify Notification payloads for threadId, staleDate, sound dictionary, and alert localization keys and arguments. These tests improve coverage for new builder features and ensure correct payload generation.
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@judepereira
Add support for all remaining APS and alert payload keys in Notification.Builder
This PR extends the
Notification.Builderto fully support the following APNS payload fields, matching Apple’s APS and alert conventions:Alert Enhancements
alert(Object)subtitlelaunch-imagetitle-loc-key,title-loc-argssubtitle-loc-key,subtitle-loc-argsloc-key,loc-argsSound Dictionary Support
sound(Map<String,Object>)soundCritical(),soundName(),soundVolume())Additional APS Headers
thread-idtarget-content-idfilter-criteriastale-datecontent-statetimestampeventdismissal-dateattributes-type/attributesAll new builder methods follow the project’s existing null-check and removal conventions.
Unit tests have been added to verify serialization of each new key.