Refactor to match ClickHouse EXPLAIN AST json=1 format - #28
Merged
Conversation
pulpdrew
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the output AST format (and the associated reference files) to match the output from ClickHouse's
EXPLAIN AST json=1AST Serializer, as implemented here.Reference AST files are now generated using a binary built from the linked branch, using the existing (now modified)
npm run generate:expected-outputs -- --ast --regenerate-all-referencesscript.The AST is a superset of the reference format, with additions now described in the README.
Also closes #25 by adding a locations option to parse.