[POC] Fix documentation generation by internally filling the database configuration field#640
Draft
koletzilla wants to merge 1 commit into
Draft
[POC] Fix documentation generation by internally filling the database configuration field#640koletzilla wants to merge 1 commit into
koletzilla wants to merge 1 commit into
Conversation
Contributor
Author
|
Note: as expected with this approach as mentioned here #311 (comment) , now some relations are wrongly named in the docs by including both schema and database parts like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE, IT'S NOT SAFE.
This is just a POC to try to understand how many changes would be required to fix #311
The issue is related to our dbt-clickhouse not filling the
databasefield on purpose. dbt uses database, schema and table to reference resources crates in the database but CH only uses 2, database and table. in dbt world, we are using instead schema and table and leave empty database to avoid errors.This impacts tools that may want to process this information to build information systems.
In this PR I'm trying to see how we can fill the database configuration in some places so:
databasetab in the docs actually have data.We need to make sure all these things are safe before moving forward with this PR