ready hm 21#31
Open
isyufu wants to merge 1 commit into
Open
Conversation
astynax
reviewed
Mar 5, 2024
|
|
||
| (defn dir-in-walk? [x] | ||
| ; [a {e {i 584}, f 29116, g 2557, h.lst 62596}] | ||
| (if (and (vector? x) (= 2 (count x)) (map? (second x))) true) |
Contributor
There was a problem hiding this comment.
(if ... true) странно выглядит. Может быть and достаточно было бы?
Contributor
There was a problem hiding this comment.
Сейчас код возвращает true или nil. Да, nil тоже "ложен", но как-то не хочется видеть в коде смешивание типов без нужды.
astynax
reviewed
Mar 5, 2024
|
|
||
| (defn dir-loc [name loc] | ||
| (let [[key value] (z/node loc)] | ||
| (if (and (= name key) (map? value)) loc) |
Contributor
There was a problem hiding this comment.
Лучше использовать when здесь.
Contributor
|
Поставил зачёт. Отличный пример использования |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.