Merged
Conversation
EC2 Image Builder added support for (auto-versioning)[https://aws.amazon.com/about-aws/whats-new/2025/11/ec2-image-builder-auto-versioning-infrastructure/]. We can get rid of our own custom versioner. See also #804
There was a problem hiding this comment.
Pull request overview
This PR removes custom versioning logic for EC2 Image Builder components in favor of AWS's newly released built-in auto-versioning feature. This simplifies the codebase by eliminating the need for a custom Lambda function and associated infrastructure to manage versions.
Key changes:
- Removed custom versioning Lambda function and related infrastructure
- Updated Image Builder resources to use static versions ('1.0.0' or '1.0.x') with dynamic version resolution
- Cleaned up configuration files to remove versioning-related build tasks
Reviewed changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/versioner.test.ts | Removed all unit tests for the custom versioning logic |
| src/image-builders/aws-image-builder/versioner.lambda.ts | Deleted custom Lambda function that managed version increments |
| src/image-builders/aws-image-builder/versioner-function.ts | Removed Lambda function wrapper class |
| src/image-builders/aws-image-builder/common.ts | Deleted base class that provided versioning functionality |
| src/image-builders/aws-image-builder/workflow.ts | Updated to use static version '1.0.0' instead of generated versions |
| src/image-builders/aws-image-builder/container.ts | Changed to use '1.0.x' version pattern and retrieve actual version from CloudFormation attribute |
| src/image-builders/aws-image-builder/ami.ts | Changed to use '1.0.x' version pattern and retrieve actual version from CloudFormation attribute |
| src/image-builders/aws-image-builder/builder.ts | Updated to use static version '1.0.0' for components |
| src/image-builders/aws-image-builder/index.ts | Removed export of common.ts module |
| package.json | Removed bundling scripts for versioner Lambda |
| .projen/tasks.json | Removed versioner Lambda bundling tasks |
| .projen/files.json | Removed versioner-function.ts from generated files list |
| .gitattributes | Removed versioner-function.ts from linguist-generated markers |
| .eslintrc.json | Removed versioner.lambda.ts from ESLint configuration |
| test/default.integ.snapshot/github-runners-test.assets.json | Updated asset hashes reflecting infrastructure changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge Queue Status✅ The pull request has been merged at ebc7fe0 This pull request spent 5 seconds in the queue, with no time running CI. Required conditions to merge |
kichik
added a commit
that referenced
this pull request
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EC2 Image Builder added support for auto-versioning. We can get rid of our own custom versioner.
See also #804