Skip to content

chore: Use built-in auto-versioning#832

Merged
mergify[bot] merged 1 commit intomainfrom
auto-version
Dec 16, 2025
Merged

chore: Use built-in auto-versioning#832
mergify[bot] merged 1 commit intomainfrom
auto-version

Conversation

@kichik
Copy link
Copy Markdown
Member

@kichik kichik commented Dec 15, 2025

EC2 Image Builder added support for auto-versioning. We can get rid of our own custom versioner.

See also #804

EC2 Image Builder added support for (auto-versioning)[https://aws.amazon.com/about-aws/whats-new/2025/11/ec2-image-builder-auto-versioning-infrastructure/]. We can get rid of our own custom versioner.

See also #804
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes custom versioning logic for EC2 Image Builder components in favor of AWS's newly released built-in auto-versioning feature. This simplifies the codebase by eliminating the need for a custom Lambda function and associated infrastructure to manage versions.

Key changes:

  • Removed custom versioning Lambda function and related infrastructure
  • Updated Image Builder resources to use static versions ('1.0.0' or '1.0.x') with dynamic version resolution
  • Cleaned up configuration files to remove versioning-related build tasks

Reviewed changes

Copilot reviewed 15 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/versioner.test.ts Removed all unit tests for the custom versioning logic
src/image-builders/aws-image-builder/versioner.lambda.ts Deleted custom Lambda function that managed version increments
src/image-builders/aws-image-builder/versioner-function.ts Removed Lambda function wrapper class
src/image-builders/aws-image-builder/common.ts Deleted base class that provided versioning functionality
src/image-builders/aws-image-builder/workflow.ts Updated to use static version '1.0.0' instead of generated versions
src/image-builders/aws-image-builder/container.ts Changed to use '1.0.x' version pattern and retrieve actual version from CloudFormation attribute
src/image-builders/aws-image-builder/ami.ts Changed to use '1.0.x' version pattern and retrieve actual version from CloudFormation attribute
src/image-builders/aws-image-builder/builder.ts Updated to use static version '1.0.0' for components
src/image-builders/aws-image-builder/index.ts Removed export of common.ts module
package.json Removed bundling scripts for versioner Lambda
.projen/tasks.json Removed versioner Lambda bundling tasks
.projen/files.json Removed versioner-function.ts from generated files list
.gitattributes Removed versioner-function.ts from linguist-generated markers
.eslintrc.json Removed versioner.lambda.ts from ESLint configuration
test/default.integ.snapshot/github-runners-test.assets.json Updated asset hashes reflecting infrastructure changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mergify mergify Bot added the queued label Dec 16, 2025
@mergify mergify Bot merged commit 86dc80a into main Dec 16, 2025
20 checks passed
@mergify
Copy link
Copy Markdown

mergify Bot commented Dec 16, 2025

Merge Queue Status

✅ The pull request has been merged at ebc7fe0

This pull request spent 5 seconds in the queue, with no time running CI.
The checks were run in-place.

Required conditions to merge

@mergify mergify Bot deleted the auto-version branch December 16, 2025 00:16
@mergify mergify Bot removed the queued label Dec 16, 2025
kichik added a commit that referenced this pull request Dec 17, 2025
mergify Bot pushed a commit that referenced this pull request Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants