Generate a kubeconfig that can be used from remote machines#49
Draft
ksuderman wants to merge 3 commits intoCloudVE:masterfrom
Draft
Generate a kubeconfig that can be used from remote machines#49ksuderman wants to merge 3 commits intoCloudVE:masterfrom
ksuderman wants to merge 3 commits intoCloudVE:masterfrom
Conversation
nuwang
force-pushed
the
master
branch
2 times, most recently
from
24160e8 to
786d73c
Compare
nuwang
reviewed
May 5, 2022
Contributor
nuwang
left a comment
nuwang
left a comment
There was a problem hiding this comment.
Also, perhaps we could rename fetch.yml to fetch_kube_config.yml?
| lineinfile: | ||
| path: "{{ temp_file }}" | ||
| regexp: 'server: https://127\.0\.0\.1:6443' | ||
| line: " server: https://{{ ansible_ssh_host }}:6443" |
Contributor
There was a problem hiding this comment.
Can cluster_hostname be used for this instead of ansible_ssh_host? If I recall correctly, cluster_hostname defaults to ansible_ssh_host if it's not specified.
Collaborator
Author
There was a problem hiding this comment.
I can test it, but I want the kubeconfig to be valid for the public IP address not just the hostname.
Contributor
There was a problem hiding this comment.
Sure, in which case you can specify the ip for cluster_hostname, which is what happens by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces PR #48
The certificates that are generated for the kubeconfig file are only valid for for localhost (127.0.0.1) and cannot be downloaded and used from a remote machine. This PR adds two things to address this problem:
{{ ansible_ssh_host }}to thetls-sansection of therke_config.j2template so that the certificates generated are also valid for the instance's public IP address, andThis PR has not been tested yet.