Skip to content

test: add Homebrew install path to local UAT #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidahmann merged 1 commit into from
Mar 3, 2026
Merged

test: add Homebrew install path to local UAT #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ make fmt # Format
make lint # Vet + golangci-lint
make test # Unit tests
make prepush-full # Full gate: lint + test + coverage + contract + integration + e2e + acceptance
make test-uat-local # UAT for source, go-install, and local release-archive install paths
make test-uat-local # UAT for source/go-install/local-release paths; add --brew for Homebrew install path
```

CI pipelines: main, PR, determinism (cross-platform), CodeQL, nightly (hardening + chaos + performance + soak), release (GoReleaser + checksums + SBOM + cosign + SLSA provenance).
Expand Down
2 changes: 1 addition & 1 deletion cmd/proof/verify_cmd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func TestVerifyBundleWithManifestSignature(t *testing.T) {

key, err := proof.GenerateSigningKey()
require.NoError(t, err)
_, err = proof.SignBundle(dir, key)
_, err = proof.SignBundleFile(dir, key)
require.NoError(t, err)

out, err := runCLIForTest(t, []string{"verify", "--bundle", "--signatures", "--public-key", hex.EncodeToString(key.Public), dir})
Expand Down
100 changes: 96 additions & 4 deletions scripts/test_uat_local.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,19 @@ REPO_ROOT="$(cd "${SCRIPT_DIR}/.." && pwd)"

OUTPUT_DIR="${REPO_ROOT}/.uat_local"
RELEASE_VERSION="${PROOF_UAT_RELEASE_VERSION:-}"
RUN_BREW_PATH="${PROOF_UAT_BREW:-0}"

usage() {
cat <<'EOF'
Run local end-to-end UAT for Proof.

Usage:
test_uat_local.sh [--output-dir <path>] [--release-version <tag>]
test_uat_local.sh [--output-dir <path>] [--release-version <tag>] [--brew]

Options:
--output-dir <path> UAT artifacts directory (default: .uat_local)
--release-version <tag> Optional GitHub release tag to validate release binary path
--brew Validate Homebrew install path (requires --release-version)
-h, --help Show this help
EOF
}
Expand All @@ -33,6 +35,10 @@ while [[ $# -gt 0 ]]; do
RELEASE_VERSION="$2"
shift 2
;;
--brew)
RUN_BREW_PATH=1
shift
;;
-h|--help)
usage
exit 0
Expand Down Expand Up @@ -231,10 +237,25 @@ create_local_release_archive() {
extract_release_binary() {
local release_dir="$1"
local extraction_dir="$2"
local platform_suffix="${3:-}"
rm -rf "${extraction_dir}"
mkdir -p "${extraction_dir}"

local archive
archive="$(find "${release_dir}" -maxdepth 1 -type f \( -name '*.tar.gz' -o -name '*.zip' \) | head -n1 || true)"
if [[ -n "${platform_suffix}" ]]; then
archive="$(
find "${release_dir}" -maxdepth 1 -type f \( -name '*.tar.gz' -o -name '*.zip' \) | sort | while IFS= read -r path; do
base="$(basename "${path}")"
if [[ "${base}" == *"_${platform_suffix}.tar.gz" || "${base}" == *"_${platform_suffix}.zip" ]]; then
printf '%s\n' "${path}"
break
fi
done
)"
fi
if [[ -z "${archive:-}" ]]; then
archive="$(find "${release_dir}" -maxdepth 1 -type f \( -name '*.tar.gz' -o -name '*.zip' \) | sort | head -n1 || true)"
fi
if [[ -z "${archive}" ]]; then
return 1
fi
Expand All @@ -255,6 +276,66 @@ extract_release_binary() {
return 0
}

host_release_platform_suffix() {
local os
local arch

case "$(uname -s)" in
Darwin) os="darwin" ;;
Linux) os="linux" ;;
MINGW*|MSYS*|CYGWIN*) os="windows" ;;
*) return 1 ;;
esac

case "$(uname -m)" in
x86_64|amd64) arch="amd64" ;;
arm64|aarch64) arch="arm64" ;;
*) return 1 ;;
esac

printf '%s_%s' "${os}" "${arch}"
}

resolve_brew_binary_path() {
local linked_prefix
local keg_prefix

linked_prefix="$(brew --prefix 2>/dev/null || true)"
if [[ -n "${linked_prefix}" && -x "${linked_prefix}/bin/proof" ]]; then
printf '%s' "${linked_prefix}/bin/proof"
return 0
fi

keg_prefix="$(brew --prefix proof 2>/dev/null || true)"
if [[ -n "${keg_prefix}" && -x "${keg_prefix}/bin/proof" ]]; then
printf '%s' "${keg_prefix}/bin/proof"
return 0
fi

return 1
}

run_brew_install_path_suite() {
local release_version="$1"
local artifacts_dir="$2"
local brew_bin
local expected_version

require_cmd brew
run_step "brew_tap" brew tap Clyra-AI/homebrew-tap
run_step "brew_install" bash -lc "set -euo pipefail; if brew list --versions proof >/dev/null 2>&1; then brew reinstall Clyra-AI/homebrew-tap/proof; else brew install Clyra-AI/homebrew-tap/proof; fi"

brew_bin="$(resolve_brew_binary_path || true)"
if [[ -z "${brew_bin}" ]]; then
log "FAIL brew_binary_resolve (proof binary not found after brew install)"
exit 1
fi

expected_version="${release_version#v}"
run_step "brew_expected_version" bash -lc "\"${brew_bin}\" --version | grep -F \"${expected_version}\""
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use exact version match for brew validation

brew_expected_version currently checks "${brew_bin}" --version with grep -F "${expected_version}", which is a substring match. This can report success for the wrong release (for example, expecting 0.4.6 will also match 0.4.60), so the new Homebrew UAT path can pass even when a different formula version is installed. This weakens the stated contract that --brew validates the requested release tag.

Useful? React with 👍 / 👎.

run_binary_contract_suite "brew" "${brew_bin}" "${artifacts_dir}"
}

require_cmd go
require_cmd python3

Expand Down Expand Up @@ -310,10 +391,11 @@ if [[ -n "${RELEASE_VERSION}" ]]; then
require_cmd gh
RELEASE_DIR="${OUTPUT_DIR}/release"
mkdir -p "${RELEASE_DIR}"
run_step "release_download" gh release download "${RELEASE_VERSION}" -R Clyra-AI/proof -D "${RELEASE_DIR}"
run_step "release_download" gh release download "${RELEASE_VERSION}" -R Clyra-AI/proof -D "${RELEASE_DIR}" --clobber

RELEASE_EXTRACT_DIR="${OUTPUT_DIR}/release_extract"
RELEASE_BIN="$(extract_release_binary "${RELEASE_DIR}" "${RELEASE_EXTRACT_DIR}" || true)"
RELEASE_PLATFORM_SUFFIX="$(host_release_platform_suffix || true)"
RELEASE_BIN="$(extract_release_binary "${RELEASE_DIR}" "${RELEASE_EXTRACT_DIR}" "${RELEASE_PLATFORM_SUFFIX}" || true)"
if [[ -z "${RELEASE_BIN}" ]]; then
log "FAIL release_binary_extract (no proof binary found in downloaded release assets)"
exit 1
Expand All @@ -323,4 +405,14 @@ else
log "SKIP release path checks (set --release-version to enable)"
fi

if [[ "${RUN_BREW_PATH}" == "1" ]]; then
if [[ -z "${RELEASE_VERSION}" ]]; then
log "FAIL brew install path checks require --release-version"
exit 1
fi
run_brew_install_path_suite "${RELEASE_VERSION}" "${ARTIFACTS_DIR}"
else
log "SKIP brew install path checks (pass --brew to enable)"
fi

log "UAT COMPLETE: PASS"
Loading