Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #83
📝 Description
Implemented authentication orchestration for 3 flows
Added 2 new endpoints to:
Note that the omchai guard will always look for :id or :anthologyId as a Param. If it does not exist then the guard will not be able to extract the anthologyId. Furthermore, from the previous version of the ticket I thought it would be helpful to make the publishedDate field on Anthology to be nullable because an anthology is not necessarily published upon being created.
✔️ Verification
🏕️ (Optional) Future Work / Notes
package.json was edited, currently you have to manually change the name you want the migration to be, so a quick fix is needed for that.
Fixed some outdated units tests not associated with this ticket for UsersService, yarn test works now.
During integration testing I found that the mock data didn't include all the fields I needed to test. The Guards depend on accessing ids through the string literal column "user", instead of "userId". I'm interested to take on a new ticket to flesh out mock data/seeding for ease of testing.