Merged
Conversation
prooflesben
requested changes
Mar 21, 2026
Collaborator
prooflesben
left a comment
prooflesben
left a comment
There was a problem hiding this comment.
Take out returning the tokens in the request. You should only be setting the cookies and return just a message saying things went well
prooflesben
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #343
📝 Description
Added refresh token functionality
Briefly list the changes made to the code:
Updated backend POST /auth/refresh to return the refreshed idToken and a refreshToken (and to set the refresh_token cookie, using Cognito’s rotated token when available).
Added frontend auto-refresh behavior in bcan/frontend/src/api.ts: on a 401 (except /auth/refresh), it calls /auth/refresh once and retries the original request.
Adjusted backend JWT guards to throw UnauthorizedException / ForbiddenException instead of silently returning false, so the frontend can reliably detect expired/invalid access tokens.
✔️ Verification
Backend tests plus running frontend