Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #163
📝 Description
Write a short summary of what you added. Why is it important? Any member of C4C should be able to read this and understand your contribution -- not just your team members.
Adds paginated GET endpoints for expenditures and reports. Both endpoints share a consistent response (data, pagination) that aligns with the donors/donations pagination added in #162.
Changes:
Added GET /expenditures with page, limit, and optional projectId filter — orders by spent_on DESC
Added GET /reports with page, limit, and optional projectId filter — orders by date_created DESC
Both return 400 for invalid pagination params (non-integer, < 1)
Wired up the reports lambda with db.ts, auth.ts, and db-types.d.ts (it was previously a stub with no DB access)
Updated OpenAPI specs and added unit + e2e tests for both endpoints
Briefly list the changes made to the code:
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Provide screenshots of any new components, styling changes, or pages.
Clone the branch and npm install inside apps/backend/lambdas/reports/
Run unit tests:
cd apps/backend/lambdas/expenditures && npm test
cd apps/backend/lambdas/reports && npm test
For e2e tests, start the DB and run:
npm run test:e2e
http://localhost:3000/expenditures/swagger
http://localhost:3000/reports/swagger
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!