Change to Next.js and pnpm#1
Conversation
… specification to latest lts version
… specification to latest lts version
| @@ -0,0 +1,3 @@ | |||
| pnpm lint | |||
| pnpm format | |||
| git add --all No newline at end of file | |||
There was a problem hiding this comment.
Developers should definitely be responsible / know what code they're committing... this absolves them of having to think about staging their changes and ultimately causes a lot of churn in CI/CD pipelines. Think like managers saying "the build servers down again? Who commited broken code?"
I see the lint/format but still... it's important to be able to know what all is being changed.
There was a problem hiding this comment.
Wait, just read this was a pre-commit hook... yeh no. pre-push is fine but really in general these things should be run by a build server.
But in lue of having a dedicated build server, I'll let this slide if we switch this lint / format over to a pre-push. But pre-commit is uber-aggressive and very anti-autonomy.
erlandsona
left a comment
erlandsona
left a comment
There was a problem hiding this comment.
Switch pre-commit -> pre-push and otherwise THANK GOD!
Of course, this also means Front-End folk could dip their toes into a little bit of Back-End stuff too if say a team were to pull in a library like drizzle-orm 😏
Not that I plan on having anyone do that but if like the python folks drop off a team or whatever, having the template be a scaffolded NextJS project opens up a LOT of potential pivoting opportunities.
nice work!
2 participants
No description provided.