Fix Error Handler#109
Open
PenguinBoi12 wants to merge 4 commits into
Open
Conversation
PenguinBoi12
force-pushed
the
fix/error-handler
branch
from
19a813b to
7054a6e
Compare
PenguinBoi12
force-pushed
the
fix/error-handler
branch
from
7054a6e to
a2f6dd5
Compare
PenguinBoi12
force-pushed
the
fix/error-handler
branch
from
86fcc75 to
fe4a4c1
Compare
chrisdedman
approved these changes
Jul 7, 2026
chrisdedman
left a comment
chrisdedman
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I left on question about the unit test, otherwise good for merging.
Comment on lines
+60
to
+64
| class BaseCustomError(Exception): | ||
| pass | ||
|
|
||
| class SubCustomError(BaseCustomError): | ||
| pass |
Contributor
There was a problem hiding this comment.
I know this is testing classes error handler, but I wonder if this could be the top header file definition as it is also used in the first unit test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Error handlers (
@bot.error,@ext.error,@cmd.error) only matched the exact exception type, so handlers registered for a base class (or the default@bot.error()fallback) silently never fired for subclasses. Extension/bot-level command errorhandlers also never ran for exceptions raised inside a command body.
Additionally, once an error was handled, the command would still send a generic "usage: ..." message and log it as unhandled.
This PR:
Type of Change
Pre-merge Checklist
pytestmypy