HMTV2-34: foodticket page#19
Open
jasutiin wants to merge 5 commits into
Open
Conversation
jasutiin
requested review from
HarshitaJindia19,
YahyaAsmara,
anthonyych4n,
burtonjong and
skand088
as code owners
jasutiin
removed request for
HarshitaJindia19,
YahyaAsmara,
anthonyych4n and
burtonjong
skand088
requested changes
May 14, 2026
Contributor
There was a problem hiding this comment.
i like the idea of the qr codes being more general but maybe lets run it by victoria on slack since its more of a UX thing? there might be possibilities of confusion if people dont see changes on the QR per meal, they might be like "why didnt i get a foodticket for X meal" ykwim.
| {initials || "P"} | ||
| </div> | ||
| <div className="space-y-2"> | ||
| <h1 className="font-black text-3xl italic leading-tight drop-shadow-[0_2px_0_rgba(0,0,0,0.08)] sm:text-4xl"> |
Contributor
There was a problem hiding this comment.
this dropshadow colour - can we add it to a global styles file and use a name here instead of hardcoding this?
| <h2 className="font-medium text-2xl uppercase">My Food Ticket</h2> | ||
| </div> | ||
|
|
||
| <div className="rounded-[28px] border-2 border-pale-grey bg-pale-grey p-5 shadow-[0_22px_50px_rgba(255,107,84,0.18)] sm:p-8"> |
Contributor
There was a problem hiding this comment.
same for this shadow colour. lets try to use vars instead of hardcodes?
the new UI design allows regular attendees to view the meal schedule, so we don't need this as an admin procedure anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first two images below is what the food ticket page looks like right now. The last one is the figma design. The labels are different in my version because I want to make the QR code a more general purpose one so that users can also use the same one to scan into different events.
It is still a work in progress, may have to merge Yahya's PR first (#17) so that I can copy what he did for the little squiggles on his page.